Skip to content

feat: new WAL file for meta#334

Open
cheb0 wants to merge 5 commits intomainfrom
311-wal-crash-recovery
Open

feat: new WAL file for meta#334
cheb0 wants to merge 5 commits intomainfrom
311-wal-crash-recovery

Conversation

@cheb0
Copy link
Member

@cheb0 cheb0 commented Jan 30, 2026

Description

A new WAL file which can withstand arbitrary failures like power shutdowns, lost disk sector writes or corrupted bytes.

There is also a new MetaBlock type which replaces DocBlock at all places where meta is transfered or stored to filesystem.

Fixes #311

  • I have read and followed all requirements in CONTRIBUTING.md;
  • I used LLM/AI assistance to make this pull request;

@github-actions
Copy link
Contributor

github-actions bot commented Jan 30, 2026

🔴 Performance Degradation

Some benchmarks have degraded compared to the previous run.
Click on Show table button to see full list of degraded benchmarks.

Show table
Name Previous Current Ratio Verdict
FindSequence_Random/small-4 174405 6e8721
10280.15 MB/s 5489.51 MB/s 0.53 🔴
24.90 ns/op 46.63 ns/op 1.87 🔴

@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2026

Codecov Report

❌ Patch coverage is 86.93182% with 46 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.44%. Comparing base (1744059) to head (792a7fa).

Files with missing lines Patch % Lines
frac/active.go 73.75% 16 Missing and 5 partials ⚠️
storage/wal_reader.go 86.07% 8 Missing and 3 partials ⚠️
storage/meta_block.go 94.11% 5 Missing and 1 partial ⚠️
storage/wal_writer.go 92.75% 3 Missing and 2 partials ⚠️
storeapi/grpc_bulk.go 0.00% 1 Missing and 1 partial ⚠️
frac/active_writer.go 85.71% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #334      +/-   ##
==========================================
- Coverage   71.65%   71.44%   -0.21%     
==========================================
  Files         204      207       +3     
  Lines       14770    15106     +336     
==========================================
+ Hits        10583    10793     +210     
- Misses       3435     3544     +109     
- Partials      752      769      +17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cheb0
Copy link
Member Author

cheb0 commented Jan 30, 2026

@seqbenchbot up main bulk

@seqbenchbot
Copy link

seqbenchbot commented Jan 30, 2026 •
edited
Loading

Nice, @cheb0 <(-^,^-)=b!

Your request was successfully served.
Identificator for your ongoing benchmark - 0c97854c.

Here is a list of helpful links:

  • Take a look at Grafana dashboard;
  • Live-tailing logs are also available;

Have a great time!

@cheb0
Copy link
Member Author

cheb0 commented Jan 30, 2026

@seqbenchbot down 0c97854c

@seqbenchbot
Copy link

seqbenchbot commented Jan 30, 2026 •
edited
Loading

Nice, @cheb0 <(-^,^-)=b!

Your request was successfully served.
The benchmark with identificator 0c97854c was stopped.

Have a great time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkharms dkharms Awaiting requested review from dkharms

@eguguchkin eguguchkin Awaiting requested review from eguguchkin

@moflotas moflotas Awaiting requested review from moflotas

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make WAL resilient to hardware crash

3 participants

@cheb0 @codecov-commenter @seqbenchbot